Skip to content

modules: wfa-qt: Fix server certificate validation #25220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

modules: wfa-qt: Fix server certificate validation #25220

wants to merge 3 commits into from

Conversation

@D-Triveni
Copy link
Contributor

@D-Triveni D-Triveni commented Oct 24, 2025

Add changes to read parameters required to
validate the server certificate.

Fixes SHEL-3880.

@D-Triveni D-Triveni requested a review from a team as a code owner October 24, 2025 06:52
@D-Triveni D-Triveni requested a review from rado17 October 24, 2025 06:52
@NordicBuilder NordicBuilder added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 24, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 24, 2025 •
edited
Loading

CI Information

To view the history of this post, click the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: b523b3fcf390e42da2c4f98f6e87b97ba9042c4a
hostap: PR head: 6086dea5ee7406e1eede7f2ca6dff1b00b0f04e2
zephyr: PR head: 046078a36489d0be7456351dafd7c7f9db3396dc

more details

sdk-nrf:

PR head: b523b3fcf390e42da2c4f98f6e87b97ba9042c4a
merge base: e4f2d9f0c5c1ce3f2b0f6d7534dbb509bf9ea727
target head (main): e4f2d9f0c5c1ce3f2b0f6d7534dbb509bf9ea727
Diff

hostap:

PR head: 6086dea5ee7406e1eede7f2ca6dff1b00b0f04e2
merge base: 5abcff1c0ecff65f0f81e0cc086b7f766e5101bf
Diff

zephyr:

PR head: 046078a36489d0be7456351dafd7c7f9db3396dc
merge base: 5ce544de9868ac2bb919b608b7b3e8d0c443f34f
target head (main): 5ce544de9868ac2bb919b608b7b3e8d0c443f34f
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (26) 
modules
│  ├── lib
│  │  ├── hostap
│  │  │  ├── hostapd
│  │  │  │  ├── hostapd_cli_zephyr.c
│  │  │  │  │ hostapd_cli_zephyr.h
│  │  │  ├── src
│  │  │  │  ├── ap
│  │  │  │  │  │ hostapd.h
│  │  │  │  ├── common
│  │  │  │  │  │ wpa_ctrl.h
│  │  │  │  ├── crypto
│  │  │  │  │  │ tls_mbedtls_alt.c
│  │  │  │  ├── drivers
│  │  │  │  │  ├── driver_zephyr.c
│  │  │  │  │  │ driver_zephyr.h
│  │  │  │  ├── utils
│  │  │  │  │  ├── includes.h
│  │  │  │  │  │ os_zephyr.c
│  │  │  ├── wpa_supplicant
│  │  │  │  ├── wpa_cli.c
│  │  │  │  ├── wpa_cli_cmds.c
│  │  │  │  ├── wpa_cli_zephyr.c
│  │  │  │  ├── wpa_cli_zephyr.h
│  │  │  │  ├── wpa_supplicant.c
│  │  │  │  │ wpa_supplicant_i.h
│  ├── wfa-qt
│  │  ├── src
│  │  │  │ indigo_api_callback_dut.c
west.yml
zephyr
│  ├── doc
│  │  ├── connectivity
│  │  │  ├── networking
│  │  │  │  ├── api
│  │  │  │  │  │ wifi.rst
│  ├── include
│  │  ├── zephyr
│  │  │  ├── net
│  │  │  │  │ wifi_mgmt.h
│  ├── modules
│  │  ├── hostap
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── src
│  │  │  │  ├── supp_api.c
│  │  │  │  ├── supp_main.h
│  │  │  │  │ wpa_cli.c
│  ├── subsys
│  │  ├── net
│  │  │  ├── l2
│  │  │  │  ├── wifi
│  │  │  │  │  │ wifi_shell.c
│  │ west.yml

Outputs:

Toolchain

Version: df3cc9d822
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:df3cc9d822_e595b21c39

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ❌ Build twister
    • sdk-nrf test count: 872
    • sdk-zephyr test count: 686
  • ❌ Integration tests
    • ❌ test-fw-nrfconnect-chip
    • ❌ test-fw-nrfconnect-nfc
    • ❌ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ❌ test-fw-nrfconnect-nrf-iot_thingy91
    • ❌ test-fw-nrfconnect-rs
    • ❌ test-fw-nrfconnect-fem
    • ❌ test-fw-nrfconnect-thread-main
    • ❌ test-sdk-find-my
    • ❌ test-fw-nrfconnect-nrf_lrcs_positioning
    • ❌ test-sdk-wifi
    • ❌ test-low-level
    • ❌ test-sdk-dfu
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
    • ⚠️ test-fw-nrfconnect-nrf_lrcs_mosh
    • ⚠️ test-fw-nrfconnect-nrf_lrcs_positioning
Disabled integration tests
    • desktop52_verification
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps-main
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-tfm
    • test-sdk-audio
    • test-sdk-mcuboot
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@D-Triveni D-Triveni added the DNM label Oct 27, 2025
krga2022
krga2022 reviewed Nov 5, 2025
View reviewed changes
@krga2022 krga2022 self-requested a review November 5, 2025 04:11
@D-Triveni D-Triveni requested review from a team as code owners November 7, 2025 08:56
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Nov 7, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
zephyr nrfconnect/sdk-zephyr@5ce544d (main) nrfconnect/sdk-zephyr#3478 nrfconnect/sdk-zephyr#3478/files

⛔ DNM label due to: 1 project with PR revision

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@D-Triveni D-Triveni force-pushed the fix_server_valid_configuration branch from 97b98cc to d901c88 Compare November 7, 2025 09:26
@github-actions
Copy link

github-actions bot commented Nov 7, 2025 •
edited
Loading

You can find the documentation preview for this PR here.

@D-Triveni D-Triveni force-pushed the fix_server_valid_configuration branch from d901c88 to 91e6bbf Compare November 11, 2025 05:42
@D-Triveni
manifest: sdk-zephyr: Pull server validation changes
4838aaf 
This change pulls in the server validation using exact
domain match and domain suffix match options.

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
@D-Triveni
modules: wfa-qt: Fix server certificate validation
9f029d8 
Add changes to read parameters required to
validate the server certificate.

Also, set the PMF option as required for the realted testcase.

Fixes SHEL-3880.

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
@D-Triveni
modules: wfa-qt: Fix build error
b523b3f 
Fix build errors that are observed after recent hostap
upmerge.

Signed-off-by: Triveni Danda <triveni.danda@nordicsemi.no>
@D-Triveni D-Triveni force-pushed the fix_server_valid_configuration branch from 8a2533d to b523b3f Compare November 17, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bama-nordic bama-nordic bama-nordic approved these changes

@krish2718 krish2718 krish2718 approved these changes

@rado17 rado17 Awaiting requested review from rado17

@Harini37 Harini37 Awaiting requested review from Harini37

@krga2022 krga2022 Awaiting requested review from krga2022

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. DNM manifest manifest-zephyr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@D-Triveni @NordicBuilder @bama-nordic @krish2718 @krga2022